Uploaded image for project: 'Geomajas Server'
  1. Geomajas Server
  2. GBE-564

PrintConfigurationServiceImpl autowires Layers

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.18.2
    • Component/s: None
    • Labels:
      None

      Description

      Why not autowire ConfigurationServiceImpl and ask that one for VectorLayer and RasterLayer?

      AS IS (shown raster only, same for vector)

      @Autowired(required = false)
      protected Map<String, RasterLayer> rasterLayerMap = new LinkedHashMap<String, RasterLayer>();
      ...
      public RasterLayerInfo getRasterLayerInfo(String layerId) {
      	return layerId == null ? null : rasterLayerMap.get(layerId).getLayerInfo();
      }
      

      COULD BE(shown raster only, same for vector)

      @Autowired
      private ConfigurationService configurationService;
      ...
      public RasterLayerInfo getRasterLayerInfo(String layerId) {
      	return configurationService.getRasterLayer(layerId).getLayerInfo();
      }
      

        Attachments

          Activity

            People

            • Assignee:
              janv Jan Venstermans
              Reporter:
              janv Jan Venstermans
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: